Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove RealtimeClock #261

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove RealtimeClock #261

wants to merge 1 commit into from

Conversation

christophfroehlich
Copy link
Contributor

RealtimeClock got deprecated on Jazzy and Rolling with their sync within the last days.

Fixes #241 and closes #23

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.08%. Comparing base (db891ef) to head (5f8fd6f).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #261      +/-   ##
==========================================
+ Coverage   70.12%   71.08%   +0.95%     
==========================================
  Files           8        7       -1     
  Lines         492      453      -39     
  Branches       84       74      -10     
==========================================
- Hits          345      322      -23     
+ Misses         92       84       -8     
+ Partials       55       47       -8     
Flag Coverage Δ
unittests 71.08% <ø> (+0.95%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@saikishor saikishor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we already did a release deprecating it.
I think we should be fine as we discussed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Is RealtimeClock() still needed with ROS 2? Hard coded loop rate
3 participants